Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script converts TGeo response file to JSON #1011

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Sep 24, 2021

From the Examples/Scripts/Detectors/TGeoDetector/tgeo-response2json.py help:

ACTS v13.0.0 (#884) changed the way the TGeo detector configuration is specified.
A JSON file is now used, instead of the previous method using Boost options,
which were often collected together in a response file (--response-file).
This script converts an old response file to the new JSON file.

To include all the required settings, this script needs to know the defaults for
any options not specified in the response file. These defaults can be obtained
by running a TGeo example with the --geo-tgeo-dump-jsonconfig=def.json option.
This script includes a hardcoded copy of these defaults (produced with ACTS v13.0.0).
These are used by default, but the latest defaults can be regenerated and used by
specifying the -d (or -c) option.

@paulgessinger paulgessinger added this to the next milestone Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1011 (e0edc76) into main (682a7bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1011   +/-   ##
=======================================
  Coverage   48.60%   48.60%           
=======================================
  Files         337      337           
  Lines       17330    17330           
  Branches     8191     8191           
=======================================
  Hits         8423     8423           
  Misses       3166     3166           
  Partials     5741     5741           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682a7bd...e0edc76. Read the comment docs.

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asalzburger asalzburger merged commit 25299ab into acts-project:main Sep 28, 2021
@paulgessinger paulgessinger modified the milestones: next, v14.0.0 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants