Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: boundParamResolution should include TError.h #1014

Merged
merged 2 commits into from
Sep 28, 2021

Conversation

wdconinc
Copy link
Contributor

TError.h, not Terror.h: Capital E, not lowercase e.

Ref: https://github.com/root-project/root/blob/master/core/foundation/inc/TError.h

TError.h: Capital E, not lowercase e.
@HadrienG2 HadrienG2 added Bug Something isn't working Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module labels Sep 25, 2021
@HadrienG2 HadrienG2 added this to the next milestone Sep 25, 2021
Copy link
Contributor

@HadrienG2 HadrienG2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No-brainer. I wonder how this ever worked.

But as a first PR, this PR needs someone with Maintainer access to trigger the CI process.

@asalzburger
Copy link
Contributor

We are not building the the scripts by default in the CI, something we can change later on.

@paulgessinger
Copy link
Member

Likely this was only run locally on macOS, which has a case-insensitive filesystem... thanks Apple...

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #1014 (5b2ec81) into main (682a7bd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1014   +/-   ##
=======================================
  Coverage   48.60%   48.60%           
=======================================
  Files         337      337           
  Lines       17330    17330           
  Branches     8191     8191           
=======================================
  Hits         8423     8423           
  Misses       3166     3166           
  Partials     5741     5741           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682a7bd...5b2ec81. Read the comment docs.

@paulgessinger paulgessinger merged commit cbc72d6 into acts-project:main Sep 28, 2021
@wdconinc wdconinc deleted the patch-1 branch September 29, 2021 20:14
@paulgessinger paulgessinger modified the milestones: next, v14.0.0 Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Component - Examples Affects the Examples module Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants