feat: Add Pythia8 python example + test #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1031 +/- ##
=======================================
Coverage 48.57% 48.57%
=======================================
Files 338 338
Lines 17369 17369
Branches 8216 8216
=======================================
Hits 8437 8437
Misses 3179 3179
Partials 5753 5753 Continue to review full report at Codecov.
|
Corentin-Allaire
approved these changes
Oct 25, 2021
There was a problem hiding this comment.
This looks good to me. Unfortunately I don't have pythia locally so I cannot test it, @paulgessinger could you run it before merging to confirm it works properly ?
|
Tested this locally, and the CI runs it as well. |
I didn't think about this... Yeah then it should be fine ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a python example script demonstrating our Pythia8 integration. It can write out particles to CSV and ROOT formats. Also adds a test for this behavior.