-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add ITk geometry example in python #1043
Conversation
This requires the `acts-detector-examples` project to be cloned somehwere, and the `itk.py` script needs to be told where it is.
Codecov Report
@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 48.57% 48.57%
=======================================
Files 338 338
Lines 17369 17369
Branches 8216 8216
=======================================
Hits 8437 8437
Misses 3179 3179
Partials 5753 5753 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I tested this and after adding on my side a json output I noticed that the OuterPixels::PositiveEndcap::Ring are missing in the geometry, I am not too sure why though...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect !
This requires the
acts-detector-examples
project to be clonedsomehwere, and the
itk.py
script needs to be told where it is./cc @asalzburger @noemina @niermann999 @Corentin-Allaire