Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add ITk geometry example in python #1043

Merged
merged 7 commits into from
Nov 3, 2021

Conversation

paulgessinger
Copy link
Member

This requires the acts-detector-examples project to be cloned
somehwere, and the itk.py script needs to be told where it is.

/cc @asalzburger @noemina @niermann999 @Corentin-Allaire

This requires the `acts-detector-examples` project to be cloned
somehwere, and the `itk.py` script needs to be told where it is.
@paulgessinger paulgessinger added this to the next milestone Oct 18, 2021
@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #1043 (fe9f6d5) into main (46acd17) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1043   +/-   ##
=======================================
  Coverage   48.57%   48.57%           
=======================================
  Files         338      338           
  Lines       17369    17369           
  Branches     8216     8216           
=======================================
  Hits         8437     8437           
  Misses       3179     3179           
  Partials     5753     5753           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46acd17...fe9f6d5. Read the comment docs.

Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I tested this and after adding on my side a json output I noticed that the OuterPixels::PositiveEndcap::Ring are missing in the geometry, I am not too sure why though...

Examples/Scripts/Python/itk.py Show resolved Hide resolved
Examples/Scripts/Python/itk.py Outdated Show resolved Hide resolved
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect !

@kodiakhq kodiakhq bot merged commit d575795 into acts-project:main Nov 3, 2021
@paulgessinger paulgessinger deleted the python-itk-example branch November 3, 2021 16:51
@paulgessinger paulgessinger modified the milestones: next, v15.0.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants