fix: Enable G4 based python tests and fix them #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had previously missed sourcing the geant4 setup script in the CI workflow, which triggers the tests that need G4 to be skipped
Codecov Report
@@ Coverage Diff @@
## main #1044 +/- ##
=======================================
Coverage 48.57% 48.57%
=======================================
Files 337 337
Lines 17343 17343
Branches 8200 8200
=======================================
Hits 8425 8425
Misses 3180 3180
Partials 5738 5738 Continue to review full report at Codecov.
|
Corentin-Allaire
approved these changes
Oct 20, 2021
paulgessinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had previously missed sourcing the geant4 setup script in the CI
workflow, which triggers the tests that need G4 to be skipped