Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Python examples/tests can be run from any directory #1074

Merged
merged 4 commits into from
Nov 9, 2021

Conversation

timadye
Copy link
Contributor

@timadye timadye commented Nov 9, 2021

Python scripts in Examples/Python/tests and Examples/Scripts/Python should access config / data files from the acts source tree by using a path relative to the script's location (also in the source tree). They should not rely on the user's CWD being in the source tree.

This was already done in many cases. This PR fixes the remaining issues.

It is now possible to run pytest from the build directory as well as the source tree.

@timadye timadye added this to the next milestone Nov 9, 2021
Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Nov 9, 2021

Codecov Report

Merging #1074 (e89698b) into main (8b6bc7a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   48.56%   48.56%           
=======================================
  Files         341      341           
  Lines       17409    17409           
  Branches     8233     8233           
=======================================
  Hits         8454     8454           
  Misses       3195     3195           
  Partials     5760     5760           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b6bc7a...e89698b. Read the comment docs.

@kodiakhq kodiakhq bot merged commit a95b3f0 into acts-project:main Nov 9, 2021
@paulgessinger paulgessinger modified the milestones: next, v15.0.0 Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants