Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update docs for python bindings #1076

Merged
merged 6 commits into from
Nov 23, 2021

Conversation

paulgessinger
Copy link
Member

There were a few problems / oversights in the python bindings documentation. Thanks to @timadye for finding them!

@paulgessinger paulgessinger added this to the next milestone Nov 15, 2021
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I tested the example script and it ran OK. It said it processed 10 events. The output files had no hits/tracks, but that's OK I suppose.

@paulgessinger
Copy link
Member Author

Hey @timadye, actually, I had left the PropagationAlgorithm stepping logger to sterileLogger=True, which makes it not accumulate any propagation steps, hence the empty files.

I've updated this PR to set that to False, this gives me non empty output now. Can you reapprove?

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #1076 (44a8b65) into main (ba86a7e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1076   +/-   ##
=======================================
  Coverage   48.64%   48.64%           
=======================================
  Files         341      341           
  Lines       17489    17489           
  Branches     8256     8256           
=======================================
  Hits         8507     8507           
  Misses       3208     3208           
  Partials     5774     5774           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba86a7e...44a8b65. Read the comment docs.

Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Now I see the propagation_steps with the "hit" positions tracing out the example detector.

I like how some low pT tracks are still individually visible.
Rz

I'm not sure of the d_x, d_y, d_z definition, but I wonder how this happens.
d_Rz

Sorry for the irrelevant plots. The change looks good, so I'll approve.

@kodiakhq kodiakhq bot merged commit b38531d into acts-project:main Nov 23, 2021
@paulgessinger paulgessinger modified the milestones: next, v15.1.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants