-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update docs for python bindings #1076
docs: Update docs for python bindings #1076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I tested the example script and it ran OK. It said it processed 10 events. The output files had no hits/tracks, but that's OK I suppose.
Hey @timadye, actually, I had left the I've updated this PR to set that to |
Codecov Report
@@ Coverage Diff @@
## main #1076 +/- ##
=======================================
Coverage 48.64% 48.64%
=======================================
Files 341 341
Lines 17489 17489
Branches 8256 8256
=======================================
Hits 8507 8507
Misses 3208 3208
Partials 5774 5774 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Now I see the propagation_steps
with the "hit" positions tracing out the example detector.
I like how some low pT tracks are still individually visible.
I'm not sure of the d_x
, d_y
, d_z
definition, but I wonder how this happens.
Sorry for the irrelevant plots. The change looks good, so I'll approve.
There were a few problems / oversights in the python bindings documentation. Thanks to @timadye for finding them!