fix: vertex constraints #1094
Merged
fix: vertex constraints #1094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 2, 2021 15:26
… seemed to have a dimension missing.
Codecov Report
@@ Coverage Diff @@
## main #1094 +/- ##
=======================================
Coverage 48.58% 48.58%
=======================================
Files 341 341
Lines 17515 17515
Branches 8263 8263
=======================================
Hits 8510 8510
Misses 3232 3232
Partials 5773 5773 Continue to review full report at Codecov.
|
paulgessinger
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This very small PR fixes the settings of position and covariance matrix of the vertex constraint in the VertexFitterAlgorithm.hpp. When I ran the Billoir fitter with the old settings, I got the following errors:
14:15:37 VertexFit ERROR Error in vertex fit with constraint.
14:15:37 VertexFit ERROR Numeric failure in calculation.
Looking at the FullBilloirVertexFitterTests.cpp in /Tests/UnitTests/Core/Vertexing, showed that the constraints had a dimension missing (and also wrong units), which resolved the issue.