test: Remove expected_failures from tests #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can lead to unnoticed unit test failures, as was the case for the TrapezoidBounds test
paulgessinger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1116 +/- ##
=======================================
Coverage 48.07% 48.07%
=======================================
Files 347 347
Lines 18090 18090
Branches 8516 8516
=======================================
Hits 8696 8696
Misses 3499 3499
Partials 5895 5895 Continue to review full report at Codecov.
|
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Dec 15, 2021
robertlangenberg
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can lead to unnoticed unit test failures, as was the case for the TrapezoidBounds test.
This PR removes all of these cases. In some spots they were present due to the tests asserting the outcome of an operation that was hard coded in surface stubs. I don't think this provides any meaningful insight anyway, so I assert the stub behavior instead (i.e. the test succeeds).