docs: More detailed information on ROOT file hash checks #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe @HadrienG2 or @timadye could review this? |
Codecov Report
@@ Coverage Diff @@
## main #1131 +/- ##
=======================================
Coverage 48.62% 48.62%
=======================================
Files 341 341
Lines 17511 17511
Branches 8244 8244
=======================================
Hits 8515 8515
Misses 3232 3232
Partials 5764 5764 Continue to review full report at Codecov.
|
asalzburger
approved these changes
Jan 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ROOT file hash regression checks seem not to work in a very obvious way. I've updated the docs and provide some more explanation, and a few suggested workflows for local testing, and how to update the hashes.