fix: Prevent FPE in AMVF if covariance is not invertible #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, as Paul mentioned I also think that treating these vertices as merged and thus discard them is the safest way to go here. |
baschlag
approved these changes
Jan 20, 2022
Codecov Report
@@ Coverage Diff @@
## main #1142 +/- ##
==========================================
- Coverage 48.18% 48.17% -0.02%
==========================================
Files 341 341
Lines 17645 17649 +4
Branches 8324 8327 +3
==========================================
Hits 8502 8502
- Misses 3368 3372 +4
Partials 5775 5775
Continue to review full report at Codecov.
|
paulgessinger
added a commit
that referenced
this pull request
Jan 20, 2022
It's unclear to me how this covariance can end up not being invertible, but it has been observed when running the ACTS AMVF in an ATLAS online context. We think it's safer to do so, and therefore discard the vertex one level up the call chain. This is the backported version of #1142 to the `v15.x` release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to me how this covariance can end up not being invertible, but it has been observed when running the ACTS AMVF in an ATLAS online context.
I briefly discussed with @baschlag whether returning
true, i.e. treating the vertex as merged is correct, and we think it's safer to do so, and therefore discard the vertex one level up the call chain.I'm going to cherry pick this PR into branch
release/v15.xto create a bugfix tag for thev15release.