Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updating itk description in python, fixes issue #1149 #1155

Merged
merged 4 commits into from
Feb 10, 2022

Conversation

noemina
Copy link
Contributor

@noemina noemina commented Feb 10, 2022

Improving the description of the ITk geometry parameters in the python file.
This fixes as well the issue #1149, caused by the wrong configuration of the HGTD extends.

Fixes #1149

@noemina noemina added this to the next milestone Feb 10, 2022
@noemina noemina added the Bug Something isn't working label Feb 10, 2022
@noemina noemina self-assigned this Feb 10, 2022
Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I have compared the results of Fatras and Digitization between the ITk created with JSON and this Python. With the small binTolerancePhi change, I get identical results in the root files.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1155 (98ce613) into main (b8c3a38) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1155   +/-   ##
=======================================
  Coverage   47.90%   47.90%           
=======================================
  Files         359      359           
  Lines       18491    18491           
  Branches     8723     8723           
=======================================
  Hits         8859     8859           
  Misses       3603     3603           
  Partials     6029     6029           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c3a38...98ce613. Read the comment docs.

Copy link
Contributor

@timadye timadye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@paulgessinger
Copy link
Member

The python format check fails, can you fix that @noemina?

@kodiakhq kodiakhq bot merged commit 5220f82 into acts-project:main Feb 10, 2022
@paulgessinger paulgessinger modified the milestones: next, v17.1.0 Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildITkGeometry in itk.py doesn't produce hits
3 participants