-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating itk description in python, fixes issue #1149 #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I have compared the results of Fatras and Digitization between the ITk created with JSON and this Python. With the small binTolerancePhi
change, I get identical results in the root files.
Codecov Report
@@ Coverage Diff @@
## main #1155 +/- ##
=======================================
Coverage 47.90% 47.90%
=======================================
Files 359 359
Lines 18491 18491
Branches 8723 8723
=======================================
Hits 8859 8859
Misses 3603 3603
Partials 6029 6029 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
The python format check fails, can you fix that @noemina? |
Improving the description of the ITk geometry parameters in the python file.
This fixes as well the issue #1149, caused by the wrong configuration of the HGTD extends.
Fixes #1149