fix: Add constant qualifiers to seed finder utilities #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the input vectors used in the seed finder utilities are currently not marked as `const` where they should be. This limits their usability in contexts where vectors are more strictly cv-qualified. We should be able to safely set these inputs as constant, which is what this commit does.
stephenswat
added
Bug
|
Should also mention this is totally my own fault #1035. 😎 |
Codecov Report
@@ Coverage Diff @@
## main #1159 +/- ##
=======================================
Coverage 47.90% 47.90%
=======================================
Files 359 359
Lines 18491 18491
Branches 8723 8723
=======================================
Hits 8859 8859
Misses 3603 3603
Partials 6029 6029
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the input vectors used in the seed finder utilities are currently not marked as
constwhere they should be. This limits their usability in contexts where vectors are more strictly cv-qualified. We should be able to safely set these inputs as constant, which is what this commit does.