-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom z bin search order #1169
Merged
kodiakhq
merged 12 commits into
acts-project:main
from
LuisFelipeCoelho:custom-zBin-looping
Mar 30, 2022
Merged
feat: Custom z bin search order #1169
kodiakhq
merged 12 commits into
acts-project:main
from
LuisFelipeCoelho:custom-zBin-looping
Mar 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
==========================================
- Coverage 47.90% 47.86% -0.04%
==========================================
Files 371 371
Lines 19395 19411 +16
Branches 9135 9145 +10
==========================================
Hits 9291 9291
- Misses 3773 3789 +16
Partials 6331 6331
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
robertlangenberg
suggested changes
Mar 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just add a few comments to make the code easier to understand and I'm happy :)
robertlangenberg
approved these changes
Mar 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a custom z looping feature,
which allows us to change the order in which
BinnedSPGroup
search for the Space Points.In the Main branch the groups are sorted in phi and z in ascending order. But in Athena z follows the order within the vector
{1, 2, 3, 4, 11, 10, 9, 8, 6, 5, 7}
This PR introduces this same custom looping approach with the vector
zBinsCustomLooping
. If it is not defined, the previous behaviour is preserved.@noemina @paulgessinger @robertlangenberg