Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom z bin search order #1169

Merged
merged 12 commits into from
Mar 30, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

This PR introduces a custom z looping feature,
which allows us to change the order in which BinnedSPGroup search for the Space Points.

In the Main branch the groups are sorted in phi and z in ascending order. But in Athena z follows the order within the vector {1, 2, 3, 4, 11, 10, 9, 8, 6, 5, 7}

This PR introduces this same custom looping approach with the vector zBinsCustomLooping. If it is not defined, the previous behaviour is preserved.

@noemina @paulgessinger @robertlangenberg

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 17, 2022

Codecov Report

Merging #1169 (2ba3381) into main (6ae8a95) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
- Coverage   47.90%   47.86%   -0.04%     
==========================================
  Files         371      371              
  Lines       19395    19411      +16     
  Branches     9135     9145      +10     
==========================================
  Hits         9291     9291              
- Misses       3773     3789      +16     
  Partials     6331     6331              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/BinnedSPGroup.hpp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/BinnedSPGroup.ipp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedfinderConfig.hpp 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@robertlangenberg robertlangenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add a few comments to make the code easier to understand and I'm happy :)

@robertlangenberg robertlangenberg added automerge Feature Development to integrate a new feature labels Mar 29, 2022
@kodiakhq kodiakhq bot merged commit 5056fe5 into acts-project:main Mar 30, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the custom-zBin-looping branch March 30, 2022 14:32
@paulgessinger paulgessinger modified the milestones: next, v18.0.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Feature Development to integrate a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants