refactor: transformCoordinates methods without InternalSpacePoint class #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1173 +/- ##
==========================================
- Coverage 47.86% 47.85% -0.01%
==========================================
Files 371 371
Lines 19411 19413 +2
Branches 9145 9148 +3
==========================================
Hits 9291 9291
- Misses 3789 3791 +2
Partials 6331 6331
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Not Using std::function, Check callable + static_assert
robertlangenberg
approved these changes
Mar 21, 2022
|
@CarloVarni can you fix the CI? |
|
@paulgessinger I should have fixed the compilation issues now. I also found an inconsistency between the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding
transformCoordinatesfunctions that does not rely only onInternalSpacePoint. These methods will accept any space point format and require the user to define a function for retrieving coordinate and covariance values (i.e.std::function<std::array<float, 6>(const external_spacepoint_t&)>). This will allow users to use it externally to ACTS.This does not remove the previous
transformCoordinatesfunctions in order to be backward compatible. However, they are adapted to use these new implementations.