feat: remaining Python examples can be chained #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I open this PR to track ongoing development and stop #1098 going stale 😄. So far I have mostly completed the digitization and seeding examples, though the latter will need more customisation options. |
Codecov Report
@@ Coverage Diff @@
## main #1174 +/- ##
=======================================
Coverage 47.86% 47.86%
=======================================
Files 372 372
Lines 19443 19443
Branches 9151 9151
=======================================
Hits 9306 9306
Misses 3806 3806
Partials 6331 6331 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
timadye
commented
Feb 28, 2022
timadye
commented
Mar 11, 2022
added 21 commits
March 30, 2022 14:51
…d digitization for now.
timadye
commented
Mar 31, 2022
timadye
commented
Mar 31, 2022
timadye
commented
Mar 31, 2022
timadye
commented
Mar 31, 2022
added 2 commits
March 31, 2022 16:50
…l, but keep same value (for now) in tests for compatibility
paulgessinger
approved these changes
Apr 1, 2022
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Apr 11, 2022
Update the Python in `Examples/Scripts/Python` to allow configuration of various full-chain examples. Continuing the work of acts-project#1098 in order to complete the proposal originally discussed in acts-project#1093.
kodiakhq bot
pushed a commit
that referenced
this pull request
Apr 13, 2022
This requires a couple of changes: 1. Turn off the log failure thresholds for the Python based tests (otherwise setup becomes too complicated) 2. Run the physmon step **before** the python based tests: if the tests fail, the physmon html page will still be uploaded and accessible this way I also change the implementation of the CKF tracks example test: it's now parametrized via pytest to run the three configurations (seeded, truth estimated, truth smeared) from before, and in addition runs it with the ODD and the generic detector. I had to drop the numerical event count checks for that to work, but that should be covered by the hash check anyway (if the count changes the hash changes). I'm also bumping the number of events for these checks from 10 to 100. Finally, sparked by #1174, I'm switching the operation mode of the physics monitoring to not fail the job even if the comparisons fail. Let's try this workflow instead: 1. We try to cover the physics monitoring scenarios with hash checks also 2. The hash checks notify us if the output changes 3. We manually check the physics monitoring HTML file to get an idea whether the output changes are expected / tolerable
kodiakhq bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
…ith full_chain_itk example (#1331) Since `itk_seeding.py` only reads the SP from csv files, and to avoid duplicated code, I decided to modify `itk_seeding.py` in the new chained style from #1174 to allow `full_chain_itk` to retrieve the ITk configuration from `itk_seeding.py` and execute the seeding in the full-chain example. We still cannot use the complete strip **standalone** configuration (`useDetailedDoubleMeasurementInfo` needs to be False) in the full-chain example because we need the strip measurement information from the SPs. In case we want to run the full-chain seeding for strips we need to implement the calculation of these values in ACTS. @paulgessinger @robertlangenberg @timadye
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the Python in
Examples/Scripts/Pythonto allow configuration of various full-chain examples.Continuing the work of #1098 in order to complete the proposal originally discussed in #1093.