Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixing units in SeedFinderConfig #1176

Merged
merged 2 commits into from
Mar 2, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

This PR fixes the units of deltaRMiddleSPRange to external ACTS units and adds deltaRMiddleSPRange, deltaRMinTopSP, deltaRMaxTopSP, deltaRMinBottomSP and deltaRMaxBottomSP to the toInternalUnits method.

@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 1, 2022

Codecov Report

Merging #1176 (e7a885a) into main (11f59e3) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1176      +/-   ##
==========================================
- Coverage   47.84%   47.83%   -0.02%     
==========================================
  Files         360      360              
  Lines       18525    18530       +5     
  Branches     8739     8739              
==========================================
  Hits         8863     8863              
- Misses       3626     3631       +5     
  Partials     6036     6036              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/SeedfinderConfig.hpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11f59e3...e7a885a. Read the comment docs.

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 1, 2022

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@paulgessinger
Copy link
Member

@LuisFelipeCoelho can you fix the conflict?

@kodiakhq kodiakhq bot merged commit 3ee4e2e into acts-project:main Mar 2, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the seeding-fixing-units branch March 2, 2022 09:30
@paulgessinger paulgessinger modified the milestones: next, v18.0.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants