Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Coulombs Unit #1179

Merged
merged 4 commits into from
Mar 9, 2022
Merged

fix: Coulombs Unit #1179

merged 4 commits into from
Mar 9, 2022

Conversation

CarloVarni
Copy link
Collaborator

Since e=1 the C unit should be C = 1/1.602176634e-19 = 6.2415091e18 so that e = 1.602176634e−19 C is respected

@paulgessinger paulgessinger added this to the next milestone Mar 1, 2022
@codecov
Copy link

codecov bot commented Mar 9, 2022

Codecov Report

Merging #1179 (3c699ce) into main (6b30469) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1179   +/-   ##
=======================================
  Coverage   47.80%   47.80%           
=======================================
  Files         360      360           
  Lines       18549    18549           
  Branches     8756     8756           
=======================================
  Hits         8867     8867           
  Misses       3633     3633           
  Partials     6049     6049           
Impacted Files Coverage Δ
Core/include/Acts/Definitions/Units.hpp 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b30469...3c699ce. Read the comment docs.

@kodiakhq kodiakhq bot merged commit 3f3038c into acts-project:main Mar 9, 2022
@paulgessinger paulgessinger modified the milestones: next, v18.0.0 Apr 4, 2022
@AJPfleger AJPfleger mentioned this pull request Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants