feat: ITk seeding example #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure we want to add the "old-style" example in the repository, also because it includes a specific ITk implementation of it. Can we try to have the example implemented using the python-binding framework? |
Codecov Report
@@ Coverage Diff @@
## main #1186 +/- ##
=======================================
Coverage 47.81% 47.81%
=======================================
Files 360 360
Lines 18591 18591
Branches 8769 8769
=======================================
Hits 8890 8890
Misses 3649 3649
Partials 6052 6052
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
We should discuss if an example containing all the configuration to run the ITk seeding should be included into ACTS or just an example showing how to configure the new seeding features. In any case, this example still does not contain the full configuration to produce a 1 to 1 comparison to ITk pixel seeds. |
…elho/acts into ITk-seeding-example
…elho/acts into ITk-seeding-example
paulgessinger
approved these changes
Mar 18, 2022
|
ok! I will work on that @paulgessinger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
ITkSeedingExample.cppto run the ITk seeding.It shows how to configure the non-equidistant binning in z (#1005), the seed confirmation cuts (#1084), the radial range for middle SP cut (#1084) and the vector containing the map of z neighbours (#1052 and #1038).
It contains all the parameters to run the seeding for ITk pixel space points (I intend to extend this to ITk strip SPs soon).
@noemina @paulgessinger