fix: Clang (13) warning in BoundingBox #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed a warning:
```
[715/1093] Building CXX object Tests/UnitTests/Core/Geo...pezoidVolumeBounds.dir/TrapezoidVolumeBoundsTests.cpp.o
In file included from ../Tests/UnitTests/Core/Geometry/TrapezoidVolumeBoundsTests.cpp:13:
In file included from ../Core/include/Acts/Geometry/TrapezoidVolumeBounds.hpp:12:
In file included from ../Core/include/Acts/Geometry/Volume.hpp:15:
../Core/include/Acts/Utilities/BoundingBox.hpp:101:3: warning: definition of implicit copy assignment operator for 'AxisAlignedBoundingBox<Acts::Volume, double, 3>' is deprecated because it has a user-declared copy constructor [-Wdeprecated-copy]
AxisAlignedBoundingBox(const self_t& other) = default;
^
../Tests/UnitTests/Core/Geometry/TrapezoidVolumeBoundsTests.cpp:40:6: note: in implicit copy assignment operator for 'Acts::AxisAlignedBoundingBox<Acts::Volume, double, 3>' first required here
bb = tvb.boundingBox(&trf);
^
1 warning generated.
```
in a build with clang-13. This PR should remove this warning by
defaulting the copy assignment operator.
Codecov Report
@@ Coverage Diff @@
## main #1189 +/- ##
=======================================
Coverage 47.80% 47.80%
=======================================
Files 360 360
Lines 18549 18550 +1
Branches 8756 8756
=======================================
+ Hits 8867 8868 +1
Misses 3633 3633
Partials 6049 6049
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
stephenswat
approved these changes
Mar 13, 2022
stephenswat
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a warning:
in a build with clang-13. This PR should remove this warning by
defaulting the copy assignment operator.