build: Add assert.h override
#1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed in a few cases, if `assert.h` was not included through `cassert`, `ACTS_FORCE_ASSERTIONS` would not do it's job because `assert` would then already be defined. This commit thus enables a couple of additional assertions.
stephenswat
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Looks good to me, can go in as is. Just for reference, if you didn't know about this you might like the macro stack that most good C pre-processors support: https://gcc.gnu.org/onlinedocs/gcc/Push_002fPop-Macro-Pragmas.html
stephenswat
added
Bug
|
I'm not sure how that would help here though? |
Codecov Report
@@ Coverage Diff @@
## main #1202 +/- ##
=======================================
Coverage 47.75% 47.75%
=======================================
Files 360 360
Lines 18616 18616
Branches 8774 8774
=======================================
Hits 8890 8890
Misses 3674 3674
Partials 6052 6052 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in a few cases, if
assert.hwas not included throughcassert,ACTS_FORCE_ASSERTIONSwould not do it's job becauseassertwould then already be defined.This commit thus enables a couple of additional assertions.