Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Download nlohmann/json zip instead of git clone #1204

Merged
merged 3 commits into from
Mar 24, 2022

Conversation

paulgessinger
Copy link
Member

Switches from getting nlohmann/json sources via git to a zip file download from GitHub. For some reason, the git repo is very large and takes a while to clone, so this method is much quicker in my testing.

@paulgessinger paulgessinger added this to the next milestone Mar 24, 2022
@paulgessinger
Copy link
Member Author

@AJPfleger: do you want to have a look at this one?

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #1204 (050b485) into main (0926824) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1204   +/-   ##
=======================================
  Coverage   47.75%   47.75%           
=======================================
  Files         360      360           
  Lines       18616    18616           
  Branches     8774     8774           
=======================================
  Hits         8890     8890           
  Misses       3674     3674           
  Partials     6052     6052           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@kodiakhq kodiakhq bot merged commit 8e168c8 into acts-project:main Mar 24, 2022
@paulgessinger paulgessinger deleted the build/nlohmann_json_zip branch March 25, 2022 07:48
@paulgessinger paulgessinger modified the milestones: next, v18.0.0 Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants