feat: change the behaviour of enableCutsForSortedSP in seedFinder #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1213 +/- ##
==========================================
+ Coverage 47.94% 47.97% +0.02%
==========================================
Files 373 373
Lines 19495 19484 -11
Branches 9152 9148 -4
==========================================
Hits 9347 9347
+ Misses 3817 3806 -11
Partials 6331 6331
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
…lipeCoelho/acts into enable-cuts-for-sorted-sp
robertlangenberg
suggested changes
Apr 1, 2022
noemina
reviewed
Apr 7, 2022
noemina
reviewed
Apr 25, 2022
robertlangenberg
approved these changes
Apr 25, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
May 10, 2022
In the seedFinder we check the compatibility between the (r,z) slope of the two seed segments with a scattering term calculated assuming the minimum pT particle expected to be reconstructed and a second check using a scattering term scaled by the actual measured pT. As discussed here in PR #1213, there was an error in these cuts. This PR fixes that same error in SeedFinderOrthogonal.
kodiakhq bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
This was included in the default seeding in PR #1213
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits
enableCutsForSortedSPinto two booleans:Instead of using
enableCutsForSortedSPto enable both the cotTheta sorting of SPs and the cut based on the sorting, this PR makesenableCutsForSortedSPenable only the sorting andskipPreviousTopSPis added for the additional cut to skip top SPs if cotThetaBB < cotThetaTFor ITk strips the cuts are not applied.
Edit: The original error calculation was fixes,
enableCutsForSortedSPwas removed since it is not needed andskipPreviousTopSPwas added to skip top SPs