ci: Decouple LCG and Ubuntu builds #1222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @stephenswat |
stephenswat
approved these changes
Mar 31, 2022
stephenswat
added
the
Infrastructure
Codecov Report
@@ Coverage Diff @@
## main #1222 +/- ##
=======================================
Coverage 47.94% 47.94%
=======================================
Files 373 373
Lines 19495 19495
Branches 9152 9152
=======================================
Hits 9347 9347
Misses 3817 3817
Partials 6331 6331 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Hmm, so it looks like the CI is still trying to run the old jobs, which it now no longer has the configuration for anymore? Or how does that work? |
|
"Required checks" in the PR UI is a UI thing, that's not defined by the job description. I'll have to override this and change the settings if we merge this. |
|
Ah, that seems... Confusing on Github's part. 🤔 |
|
Ok, fixed conflicts. Can we go again @stephenswat ? |
paulgessinger
added a commit
to paulgessinger/acts
that referenced
this pull request
Apr 28, 2022
Based on acts-project#1222 With acts-project#1222 in, we can have the python level tests and the perf monitoring fail independently of one another. This PR enables that again. Also bumps `histcmp` to v0.4.0 for a fix for missing legends in some plots, and to include standalone PDFs in addition to the HTML report.
|
Ok, required old checks are still listed, new ones have passed. Overriding check requirement to merge this then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows getting rid of some
if/elsebranching between these, and allows splitting up the follow up checks (examples+pytest and phys monitoring) into separate jobs that depend on the build job result. This means they can run independently of each other and if either fails, the other will still run and provide output.