Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: GPU-CI for Exa.TrkX plugin #1224

Merged
merged 22 commits into from
Apr 13, 2022
Merged

Conversation

benjaminhuth
Copy link
Member

@benjaminhuth benjaminhuth commented Apr 5, 2022

This PR tries to get the GPU-CI for the Exa.TrkX plugin working.

For now the ONNX-model-files are retrieved by the job via HTTP.

@benjaminhuth benjaminhuth added the 🚧 WIP Work-in-progress label Apr 5, 2022
@benjaminhuth benjaminhuth added this to the WIP milestone Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #1224 (d335c4e) into main (6e1fd31) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1224   +/-   ##
=======================================
  Coverage   47.94%   47.94%           
=======================================
  Files         373      373           
  Lines       19495    19495           
  Branches     9152     9152           
=======================================
  Hits         9347     9347           
  Misses       3817     3817           
  Partials     6331     6331           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@benjaminhuth benjaminhuth added Infrastructure Changes to build tools, continous integration, ... Component - Plugins Affects one or more Plugins labels Apr 5, 2022
@benjaminhuth benjaminhuth removed the 🚧 WIP Work-in-progress label Apr 11, 2022
@paulgessinger
Copy link
Member

Would it be useful to add an output hash check on the output root file? That would maybe give us a heads-up if it changes? Doesn't have to be through pytest, but could be. This can also be done in a separate PR to get this in sooner.

@benjaminhuth
Copy link
Member Author

I think since the current ONNX files are still the "dummy" ones, that do not produce useful output. Once this is fixed, we should definitively add the hash checks, but I would do this in a follow-up PR

@paulgessinger
Copy link
Member

Ok. I just fixed a bug that made rerequested check suites get the wrong clone url. Can you push an empty commit to retrigger the CI, @benjaminhuth?

Copy link
Member

@paulgessinger paulgessinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok let's go.

@kodiakhq kodiakhq bot merged commit 2f5f06a into acts-project:main Apr 13, 2022
@benjaminhuth benjaminhuth deleted the ci/exatrkx-ci branch April 13, 2022 11:44
@paulgessinger paulgessinger modified the milestones: WIP, v19.0.0 Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Plugins Affects one or more Plugins Infrastructure Changes to build tools, continous integration, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants