-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: GPU-CI for Exa.TrkX plugin #1224
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1224 +/- ##
=======================================
Coverage 47.94% 47.94%
=======================================
Files 373 373
Lines 19495 19495
Branches 9152 9152
=======================================
Hits 9347 9347
Misses 3817 3817
Partials 6331 6331 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Would it be useful to add an output hash check on the output root file? That would maybe give us a heads-up if it changes? Doesn't have to be through pytest, but could be. This can also be done in a separate PR to get this in sooner. |
I think since the current ONNX files are still the "dummy" ones, that do not produce useful output. Once this is fixed, we should definitively add the hash checks, but I would do this in a follow-up PR |
Ok. I just fixed a bug that made rerequested check suites get the wrong clone url. Can you push an empty commit to retrigger the CI, @benjaminhuth? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok let's go.
This PR tries to get the GPU-CI for the Exa.TrkX plugin working.
For now the ONNX-model-files are retrieved by the job via HTTP.