feat: change rMax invalid_argument to warning

[LuisFelipeCoelho]

This PR allows for rMax in the grid to be different than the one used in BinnedSPGroup. Instead of throwing std::invalid_argument it just dumps a warning.

This is useful for ITk strip SPs. But in case we don't want to change the invalid_argument check, another option would be to add another parameter in the calculation of numRBins = (config.rMax + config.beamPos.norm()) that allows for an increase or decrease of this value.

@noemina @robertlangenberg @paulgessinger

[codecov]

Codecov Report

Merging #1227 (277321d) into main (2f5f06a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1227   +/-   ##
=======================================
  Coverage   47.94%   47.94%           
=======================================
  Files         373      373           
  Lines       19495    19495           
  Branches     9152     9152           
=======================================
  Hits         9347     9347           
  Misses       3817     3817           
  Partials     6331     6331           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[robertlangenberg]

Sorry, I rescind the approval, I think a "correct" configuration shouldn't produce a warning, your suggestion to add the beamSpot.norm() to the rBins is a much nicer approach.

[robertlangenberg]

Do the ITK strips only require to increase the rBins by the beamSpot.norm? (since you also talked about reducing the number of rBins)

[LuisFelipeCoelho]

@robertlangenberg the beamSpot.norm() is already there, I thought I could add one more parameter besides beamSpot.norm(): numRBins = (config.rMax + config.beamPos.norm() + config.newParameter)

Yes, the ITK strips only require an increase to the rBins.