-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add ccache to CI builds #1245
Conversation
I've been using it with athena/cmake and even before with root from 90s - if the build system can keep a cache of relevant files it makes a huge saving. |
Jup. I think I tested this at some point, but either GH actions cache wasn't ready yet or I couldn't get it to work. Not sure anymore. |
Codecov Report
@@ Coverage Diff @@
## main #1245 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 375 375
Lines 19588 19588
Branches 9214 9214
=======================================
Hits 9382 9382
Misses 3822 3822
Partials 6384 6384 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Ok, the most recent CI run was pretty fast again. I guess we can merge this and see how it behaves in practice. @andiwand can you review (and approve) this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good 👍 thanks for bringing this in!
@andiwand once you're happy you'll have to hit approve one more time so the PR goes green. EDIT: I need to revert the change to |
After @andiwand suggested it, I looked at this again, and it could potentially improve our build times significantly.
The caching here follows GitHubs caching implementation, where the cache is scoped to the branch in addition to what we configure. New PR branches (also from forks apparently) should be seeded from the main branch's cache, which is nice.