Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add ccache to CI builds #1245

Merged
merged 24 commits into from
May 9, 2022
Merged

Conversation

paulgessinger
Copy link
Member

@paulgessinger paulgessinger commented May 6, 2022

After @andiwand suggested it, I looked at this again, and it could potentially improve our build times significantly.

The caching here follows GitHubs caching implementation, where the cache is scoped to the branch in addition to what we configure. New PR branches (also from forks apparently) should be seeded from the main branch's cache, which is nice.

@paulgessinger paulgessinger added the 🚧 WIP Work-in-progress label May 6, 2022
@paulgessinger paulgessinger added this to the next milestone May 6, 2022
@jmasik
Copy link

jmasik commented May 6, 2022

I've been using it with athena/cmake and even before with root from 90s - if the build system can keep a cache of relevant files it makes a huge saving.

@paulgessinger
Copy link
Member Author

Jup. I think I tested this at some point, but either GH actions cache wasn't ready yet or I couldn't get it to work. Not sure anymore.

@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #1245 (145be65) into main (538fd0b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1245   +/-   ##
=======================================
  Coverage   47.89%   47.89%           
=======================================
  Files         375      375           
  Lines       19588    19588           
  Branches     9214     9214           
=======================================
  Hits         9382     9382           
  Misses       3822     3822           
  Partials     6384     6384           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andiwand andiwand mentioned this pull request May 9, 2022
@paulgessinger
Copy link
Member Author

Ok, the most recent CI run was pretty fast again. I guess we can merge this and see how it behaves in practice.

@andiwand can you review (and approve) this PR?

@paulgessinger paulgessinger removed the 🚧 WIP Work-in-progress label May 9, 2022
Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍 thanks for bringing this in!

.github/workflows/analysis.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Outdated Show resolved Hide resolved
.github/workflows/builds.yml Show resolved Hide resolved
@paulgessinger
Copy link
Member Author

paulgessinger commented May 9, 2022

@andiwand once you're happy you'll have to hit approve one more time so the PR goes green.

EDIT: I need to revert the change to linux_nodeps. There we intentionally don't source the LCG setup script.

@kodiakhq kodiakhq bot merged commit 7ec504f into acts-project:main May 9, 2022
@paulgessinger paulgessinger deleted the ccache-2022 branch May 9, 2022 14:23
@paulgessinger paulgessinger modified the milestones: next, v19.1.0 May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants