feat: Increase robustness of Python setup script #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenswat
added
Improvement
|
Wonderful, it looks like the Github runners are having some trouble. 😢 |
Codecov Report
@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 375 375
Lines 19588 19588
Branches 9214 9214
=======================================
Hits 9382 9382
Misses 3822 3822
Partials 6384 6384 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
It's failing to download G4 data files from CERN. Should hopefully be transient. |
stephenswat
force-pushed
the
build/zsh_python_setup
branch
2 times, most recently
from
687531f
to
b69785f
Compare
AJPfleger
reviewed
May 11, 2022
We've previously run into some minor issues with the Python setup script. This is only natural because shell scripting is hell, but we can still try to make it a little more robust. To this end, this commit adds two new features to the setup script: 1. The setup script now supports ZSH as well as Bash, so it should also work on Mac operating systems. 2. The script now tells the user which version of Python the bindings were set up for, so they don't run into versioning conflicts.
stephenswat
force-pushed
the
build/zsh_python_setup
branch
from
b69785f
to
92b8ab0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've previously run into some minor issues with the Python setup script. This is only natural because shell scripting is hell, but we can still try to make it a little more robust. To this end, this commit adds two new features to the setup script: