fix: ODD with macOS #1258
Merged
fix: ODD with macOS #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corentin-Allaire
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #1258 +/- ##
=======================================
Coverage 47.89% 47.89%
=======================================
Files 375 375
Lines 19588 19588
Branches 9214 9214
=======================================
Hits 9382 9382
Misses 3822 3822
Partials 6384 6384 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
paulgessinger
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the common.py to be able to use the ODD with macOs. It also make the error message a bit more explicite if the path to the ODD factory was not set.