-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: MultiTrajectory backends #1262
feat!: MultiTrajectory backends #1262
Conversation
implement dummy VectorMultiTrajectory and adjust fitters
Codecov Report
@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
+ Coverage 47.46% 47.83% +0.36%
==========================================
Files 375 380 +5
Lines 19842 20149 +307
Branches 9293 9371 +78
==========================================
+ Hits 9418 9638 +220
- Misses 4045 4063 +18
- Partials 6379 6448 +69
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Following @timadye's suggestions, I'll try to replace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments (more questions realy).
One thing that I missed to spot, and was curious was creation of new track states
in CKF, KF or GSF and how this changes with backend?
FYI I'm working on a follow-up update that uses CRTP instead of virtual functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just took a quick look - will follow up later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I could not provide valuable feedback but highlighted some todo / fixme / commented code
Thanks @andiwand, mostly things I missed when cleaning up. Should all be addressed with the most recent commit. |
This PR decouples the interface of
MultiTrajectory
from the storage backend. The default storage backend is practically identical to the previous implementation, but it's now behind the interface. This change is intended to allow seamless integration with experiment specific EDM backends, like ATLAS' xAOD.See these slides for some more information.
BREAKING CHANGE: The template parameters of
CombinatorialKalmanFilter
,KalmanFitter
andGaussianSumFitter
changes toRelated classes (options, extensions, result) also change, gaining a
traj_t
template parameter. This parameter is the type of the memory backend.