-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow passing seed quality to seeds #1268
Merged
robertlangenberg
merged 9 commits into
acts-project:main
from
noemina:add-quality-to-seed
Jun 8, 2022
Merged
feat: Allow passing seed quality to seeds #1268
robertlangenberg
merged 9 commits into
acts-project:main
from
noemina:add-quality-to-seed
Jun 8, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI: @LuisFelipeCoelho |
Codecov Report
@@ Coverage Diff @@
## main #1268 +/- ##
==========================================
- Coverage 47.48% 47.48% -0.01%
==========================================
Files 376 376
Lines 19819 19820 +1
Branches 9308 9308
==========================================
Hits 9412 9412
- Misses 4017 4018 +1
Partials 6390 6390
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
noemina
force-pushed
the
add-quality-to-seed
branch
from
May 25, 2022 12:34
8fb8a62
to
c888d20
Compare
robertlangenberg
approved these changes
May 25, 2022
LuisFelipeCoelho
added
Component - Core
Affects the Core module
Improvement
Changes to an existing feature
Impact - Minor
Nuissance bug and/or affects only a single module
automerge
labels
May 31, 2022
noemina
force-pushed
the
add-quality-to-seed
branch
from
June 3, 2022 09:36
3729bea
to
efd1d95
Compare
Do you see any problem with this PR or can be merged? |
robertlangenberg
approved these changes
Jun 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge
Component - Core
Affects the Core module
Impact - Minor
Nuissance bug and/or affects only a single module
Improvement
Changes to an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to store and retrieve the quality of the seed once created.