Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow passing seed quality to seeds #1268

Merged
merged 9 commits into from
Jun 8, 2022

Conversation

noemina
Copy link
Contributor

@noemina noemina commented May 24, 2022

This PR allows to store and retrieve the quality of the seed once created.

@noemina noemina added this to the next milestone May 24, 2022
@noemina
Copy link
Contributor Author

noemina commented May 24, 2022

FYI: @LuisFelipeCoelho

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1268 (7eded46) into main (8a2260b) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1268      +/-   ##
==========================================
- Coverage   47.48%   47.48%   -0.01%     
==========================================
  Files         376      376              
  Lines       19819    19820       +1     
  Branches     9308     9308              
==========================================
  Hits         9412     9412              
- Misses       4017     4018       +1     
  Partials     6390     6390              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/Seed.hpp 0.00% <0.00%> (ø)
Core/include/Acts/Seeding/SeedFilter.ipp 0.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Improvement Changes to an existing feature Impact - Minor Nuissance bug and/or affects only a single module automerge labels May 31, 2022
@noemina
Copy link
Contributor Author

noemina commented Jun 7, 2022

Do you see any problem with this PR or can be merged?

@robertlangenberg robertlangenberg enabled auto-merge (squash) June 7, 2022 12:26
@robertlangenberg robertlangenberg merged commit f9a0979 into acts-project:main Jun 8, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.2.0 Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants