fix: Output ROOT file closing on destruct #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I believe the writing should happen in `endRun`, I've seen segfaults when ROOT's exit handler tries to close them and sees corrupted memory. This PR should fix that for these two classes.
Codecov Report
@@ Coverage Diff @@
## main #1296 +/- ##
=======================================
Coverage 47.43% 47.43%
=======================================
Files 375 375
Lines 19785 19785
Branches 9290 9290
=======================================
Hits 9385 9385
Misses 4020 4020
Partials 6380 6380 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Does this problem affect only these two classes? I am asking, because we use the same approach for some/all other writer-classes. |
|
We certainly could. I saw crashes for these two classes specifically, so those are the ones I touched for now. |
AJPfleger
approved these changes
Jul 4, 2022
|
We could extend the scope of #881 for this purpose, @AJPfleger? |
|
Yes, #881 seems well suited. |
AJPfleger
added
Impact - Minor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I believe the writing should happen in
endRun, I've seensegfaults when ROOT's exit handler tries to close them and sees
corrupted memory. This PR should fix that for these two classes.