fix: full chain vertexing #1299
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1299 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 380 380
Lines 20164 20164
Branches 9387 9387
=======================================
Hits 9632 9632
Misses 4083 4083
Partials 6449 6449
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
there is actually an in-chain vertexing https://github.com/acts-project/acts/blob/main/Examples/Python/tests/test_examples.py#L949 |
…nto fix-full-chain-vertexing
…nto fix-full-chain-vertexing
…nto fix-full-chain-vertexing
Examples/Algorithms/Vertexing/src/AdaptiveMultiVertexFinderAlgorithm.cpp
Show resolved
Hide resolved
AJPfleger
added
the
Impact - Minor
|
sadly this still does not work. I tried to use more particles for each event. I suspected that missing seeds for one of the particles would put the vertex fit in a bad position. I think this is still true but since there are so many duplicates for each track the order in which they go into the vertexing could still result into the same problem the good news is that using #1363 seems to eliminate all the problems |
|
after merging #1363 the full chain vertexing works now |
|
ready @paulgessinger ? |
|
Looks ok, let's go with IVF first and look into AMVF. Do you know if AMVF runs into errors in the current status? |
AMVF will produce an error in the current scenario. I guess it is because we loose one of the muons and then fail to fit the vertex. with 4 muons AMVF works but IVF even works with 2 but I am not sure why |
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
|
|
paulgessinger
added
the
backport develop/v19.x
fix full chain odd vertexing added here #1286 some early discussion here https://mattermost.web.cern.ch/acts/pl/m6psyge3apgcucesrgojeaajny - output track parameters from `TrackFindingAlgorithm` - refactor error handling in `*VertexFinderAlgorithm` - rewire default whiteboard names in python examples - use IVF in `full_chain_odd.py` with 2 muons (which should give us an actual vertex) (cherry picked from commit 884d342)
Backport 884d342 from #1299. --- fix full chain odd vertexing added here #1286 some early discussion here https://mattermost.web.cern.ch/acts/pl/m6psyge3apgcucesrgojeaajny - output track parameters from `TrackFindingAlgorithm` - refactor error handling in `*VertexFinderAlgorithm` - rewire default whiteboard names in python examples - use IVF in `full_chain_odd.py` with 2 muons (which should give us an actual vertex)
fix full chain odd vertexing added here #1286
some early discussion here https://mattermost.web.cern.ch/acts/pl/m6psyge3apgcucesrgojeaajny
TrackFindingAlgorithm*VertexFinderAlgorithmfull_chain_odd.pywith 2 muons (which should give us an actual vertex)