Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Compute material variance in material mapping #1318

Merged
merged 8 commits into from
Jul 26, 2022

Conversation

Corentin-Allaire
Copy link
Contributor

This PR is in preparation to the one that will add the automatic optimisation of the material mapping.

In this PR we add the option of computing the material variance of each bin. For this, the material mapping need to be run a second time with the material map used as an input. This is control by an option and will thus not affect the performance if not turned on.

This PR also include a new material decorator that can be used as an input for the mapping, this decorator takes in input a map of ID and binning size and use it to create protomaterial for all the mapping surface (this will allow us to change the binning of the material without having to change the input json file).

@Corentin-Allaire Corentin-Allaire added Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Component - Examples Affects the Examples module Feature Development to integrate a new feature labels Jul 11, 2022
@Corentin-Allaire Corentin-Allaire added this to the next milestone Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #1318 (64ba122) into main (989bbac) will decrease coverage by 0.04%.
The diff coverage is 39.13%.

❗ Current head 64ba122 differs from pull request most recent head 326464e. Consider uploading reports for the commit 326464e to get more accurate results

@@            Coverage Diff             @@
##             main    #1318      +/-   ##
==========================================
- Coverage   47.47%   47.43%   -0.05%     
==========================================
  Files         375      375              
  Lines       19782    19825      +43     
  Branches     9272     9299      +27     
==========================================
+ Hits         9392     9404      +12     
- Misses       4010     4033      +23     
- Partials     6380     6388       +8     
Impacted Files Coverage Δ
...clude/Acts/Material/AccumulatedSurfaceMaterial.hpp 100.00% <ø> (ø)
...re/include/Acts/Material/SurfaceMaterialMapper.hpp 50.00% <ø> (ø)
Core/src/Material/SurfaceMaterialMapper.cpp 7.77% <0.00%> (-0.66%) ⬇️
Core/src/Material/AccumulatedSurfaceMaterial.cpp 41.42% <35.29%> (-1.97%) ⬇️
Core/src/Material/AccumulatedMaterialSlab.cpp 86.20% <92.30%> (+4.95%) ⬆️
Core/include/Acts/Propagator/Propagator.ipp 43.58% <0.00%> (-7.05%) ⬇️
Core/src/Surfaces/CylinderBounds.cpp 42.15% <0.00%> (-0.57%) ⬇️
Core/src/Utilities/Logger.cpp 30.43% <0.00%> (ø)
Core/src/Geometry/LayerCreator.cpp 18.04% <0.00%> (ø)
Core/src/Surfaces/AnnulusBounds.cpp 23.66% <0.00%> (ø)
... and 6 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@kodiakhq kodiakhq bot merged commit c509200 into acts-project:main Jul 26, 2022
@paulgessinger paulgessinger modified the milestones: next, v19.6.0 Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Component - Core Affects the Core module Component - Examples Affects the Examples module Feature Development to integrate a new feature Impact - Minor Nuissance bug and/or affects only a single module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants