fix: propagation bug in GSF #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #1326 +/- ##
=======================================
Coverage 47.44% 47.45%
=======================================
Files 375 375
Lines 19779 19780 +1
Branches 9274 9274
=======================================
+ Hits 9385 9386 +1
Misses 4010 4010
Partials 6384 6384
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
paulgessinger
approved these changes
Jul 15, 2022
andiwand
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that could lead to a infinite-loop in the propagation (and thus to the "reached step limit" error). The problem was that this did reset the
currentSurfacetonullptrregardeless if it hat a valid value before.