fix: any direction for helical track linearizer #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1363 +/- ##
==========================================
- Coverage 47.83% 47.83% -0.01%
==========================================
Files 380 380
Lines 20149 20150 +1
Branches 9371 9373 +2
==========================================
Hits 9638 9638
Misses 4063 4063
- Partials 6448 6449 +1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
paulgessinger
added
the
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Aug 4, 2022
Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation. @asalzburger mentioned that it would be good to back propagate from the first measurement of the particle on the track as this will always be "ahead" of the vertex cc @paulgessinger (cherry picked from commit 8639c37)
kodiakhq bot
pushed a commit
that referenced
this pull request
Aug 4, 2022
…velop/v19.x] (#1377) Backport 8639c37 from #1363. --- Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation. @asalzburger mentioned that it would be good to back propagate from the first measurement of the particle on the track as this will always be "ahead" of the vertex cc @paulgessinger
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-develop/v9.1.x develop/v9.1.x
# Navigate to the new working tree
cd .worktrees/backport-develop/v9.1.x
# Create a new branch
git switch --create backport-1363-to-develop/v9.1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 8639c37faff32a288e2417df0a7f099131132b35
# Push it to GitHub
git push --set-upstream origin backport-1363-to-develop/v9.1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-develop/v9.1.xThen, create a pull request where the |
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Sep 7, 2022
Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation. @asalzburger mentioned that it would be good to back propagate from the first measurement of the particle on the track as this will always be "ahead" of the vertex cc @paulgessinger
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Sep 7, 2022
Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation.
paulgessinger
added a commit
that referenced
this pull request
Sep 7, 2022
…velop/v9.1.x] (#1498) fix: any direction for helical track linearizer (#1363) Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation. Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
acts-project-service
pushed a commit
that referenced
this pull request
Sep 7, 2022
Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation. @asalzburger mentioned that it would be good to back propagate from the first measurement of the particle on the track as this will always be "ahead" of the vertex cc @paulgessinger (cherry picked from commit 8639c37)
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 7, 2022
…velop/v19.0.x] (#1499) Backport 8639c37 from #1363. --- Previously the `HelicalTrackLinearizer` assumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation. @asalzburger mentioned that it would be good to back propagate from the first measurement of the particle on the track as this will always be "ahead" of the vertex cc @paulgessinger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the
HelicalTrackLinearizerassumed that the vertex we are fitting has to be reachable by back propagation. This is not always the case. In this PR we try to estimate the direction in which we will find the vertex and use it for the propagation.@asalzburger mentioned that it would be good to back propagate from the first measurement of the particle on the track as this will always be "ahead" of the vertex
cc @paulgessinger