fix: Refactor and fix component merging for GSF #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
Codecov Report
@@ Coverage Diff @@
## main #1364 +/- ##
==========================================
+ Coverage 48.47% 48.58% +0.10%
==========================================
Files 381 381
Lines 20699 20727 +28
Branches 9503 9497 -6
==========================================
+ Hits 10034 10070 +36
+ Misses 4112 4110 -2
+ Partials 6553 6547 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
paulgessinger
added
the
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Oct 11, 2022
Fixes a bug in the component merging where the covariance was computed without respecting cyclic coordinates This did blow up the variance in some cases and did lead to change of direction for some components. Additional to this, now the surface-type dependent behavior (with the `AngleDescription`) should be applied in all places where the component merging is used. This also completely redid the unit test for the component merging, that should do a better job in testing the functionality. (cherry picked from commit c27fa44)
paulgessinger
pushed a commit
that referenced
this pull request
Oct 13, 2022
…velop/v19.x] (#1592) Fixes a bug in the component merging where the covariance was computed without respecting cyclic coordinates This did blow up the variance in some cases and did lead to change of direction for some components. Additional to this, now the surface-type dependent behavior (with the `AngleDescription`) should be applied in all places where the component merging is used. This also completely redid the unit test for the component merging, that should do a better job in testing the functionality. Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in the component merging where the covariance was computed without respecting cyclic coordinates
This did blow up the variance in some cases and did lead to change of direction for some components.
Additional to this, now the surface-type dependent behavior (with the
AngleDescription) should be applied in all places where the component merging is used.This also completely redid the unit test for the component merging, that should do a better job in testing the functionality.