ci: Cleaned up the workflow files a little. #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiwand
reviewed
Aug 5, 2022
Codecov Report
@@ Coverage Diff @@
## main #1384 +/- ##
=======================================
Coverage 47.76% 47.76%
=======================================
Files 380 380
Lines 20164 20164
Branches 9387 9387
=======================================
Hits 9632 9632
Misses 4083 4083
Partials 6449 6449 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
paulgessinger
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were many instances of trailing
--in the CMake commands, followed by nothing, which I removed. Moreover, many of the targets were passed to the underlying build system as a build-system-specific flag. I changed those to make it so that the--targetCMake flag is used.