Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add docs clean target to cmake #1393

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

paulgessinger
Copy link
Member

This PR adds a target docs-clean to CMake which will clean out all files generated by the docs build.

@paulgessinger paulgessinger added the Component - Documentation Affects the documentation label Aug 8, 2022
@paulgessinger paulgessinger added this to the next milestone Aug 8, 2022
Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@andiwand
Copy link
Contributor

andiwand commented Aug 8, 2022

should we include a dependency from docs to docs-clean so we always get a fresh build?

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1393 (e2d1e3c) into main (ba1e563) will not change coverage.
The diff coverage is n/a.

❗ Current head e2d1e3c differs from pull request most recent head 756171b. Consider uploading reports for the commit 756171b to get more accurate results

@@           Coverage Diff           @@
##             main    #1393   +/-   ##
=======================================
  Coverage   47.76%   47.76%           
=======================================
  Files         380      380           
  Lines       20164    20164           
  Branches     9387     9387           
=======================================
  Hits         9632     9632           
  Misses       4083     4083           
  Partials     6449     6449           
Impacted Files Coverage Δ
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.ipp 46.00% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@paulgessinger
Copy link
Member Author

should we include a dependency from docs to docs-clean so we always get a fresh build?

Not sure. That would take longer to run every time.

@paulgessinger paulgessinger changed the title docs: Add docs clean target to cmake xdocs: Add docs clean target to cmake Aug 10, 2022
@paulgessinger paulgessinger changed the title xdocs: Add docs clean target to cmake docs: Add docs clean target to cmake Aug 10, 2022
@paulgessinger paulgessinger changed the title docs: Add docs clean target to cmake xdocs: Add docs clean target to cmake Aug 10, 2022
@paulgessinger paulgessinger changed the title xdocs: Add docs clean target to cmake docs: Add docs clean target to cmake Aug 10, 2022
@kodiakhq kodiakhq bot merged commit 968993e into acts-project:main Aug 10, 2022
@paulgessinger paulgessinger deleted the docs-clean branch August 10, 2022 08:49
@paulgessinger paulgessinger modified the milestones: next, v20.0.0 Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants