Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: polish tgeo plugin doc #1397

Merged
merged 3 commits into from
Jan 18, 2023
Merged

Conversation

niermann999
Copy link
Contributor

I did not find much to change, just a few typos and a mentioning of the surface splitting, I also made the figure captions visible.

TODO: Add link to examples, once TGeoDetector is described there

@niermann999 niermann999 changed the title ref: polish tgeo plugin doc refactor: polish tgeo plugin doc Aug 8, 2022
@niermann999 niermann999 added this to the next milestone Aug 8, 2022
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #1397 (7543b26) into main (f44f1da) will decrease coverage by 0.96%.
The diff coverage is n/a.

❗ Current head 7543b26 differs from pull request most recent head a00cef2. Consider uploading reports for the commit a00cef2 to get more accurate results

@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   49.54%   48.59%   -0.96%     
==========================================
  Files         407      381      -26     
  Lines       22618    20650    -1968     
  Branches    10318     9475     -843     
==========================================
- Hits        11207    10034    -1173     
+ Misses       4230     4064     -166     
+ Partials     7181     6552     -629     
Impacted Files Coverage Δ
Core/src/Geometry/VolumeBounds.cpp 0.00% <0.00%> (-100.00%) ⬇️
Core/include/Acts/Geometry/BoundarySurfaceFace.hpp 0.00% <0.00%> (-55.56%) ⬇️
Core/src/Surfaces/RectangleBounds.cpp 33.33% <0.00%> (-53.34%) ⬇️
Core/include/Acts/Surfaces/Surface.hpp 33.33% <0.00%> (-33.34%) ⬇️
Core/src/Definitions/Common.cpp 0.00% <0.00%> (-32.00%) ⬇️
...Acts/Utilities/detail/gaussian_mixture_helpers.hpp 17.85% <0.00%> (-30.36%) ⬇️
Core/include/Acts/Geometry/ProtoLayer.hpp 75.00% <0.00%> (-25.00%) ⬇️
Core/include/Acts/Utilities/KDTree.hpp 57.93% <0.00%> (-19.07%) ⬇️
...ore/include/Acts/Geometry/CylinderVolumeBounds.hpp 49.15% <0.00%> (-13.56%) ⬇️
Core/include/Acts/Geometry/BoundarySurfaceT.hpp 58.33% <0.00%> (-9.67%) ⬇️
... and 185 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@niermann999 niermann999 changed the title refactor: polish tgeo plugin doc docs: polish tgeo plugin doc Aug 8, 2022
@paulgessinger paulgessinger added 🚧 WIP Work-in-progress Component - Documentation Affects the documentation labels Aug 9, 2022
@stale
Copy link

stale bot commented Oct 16, 2022

This issue/PR has been automatically marked as stale because it has not had recent activity. The stale label will be removed if any interaction occurs.

@stale stale bot added the Stale label Oct 16, 2022
Copy link
Member

@benjaminhuth benjaminhuth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could also merge this in the current state, what do you think @niermann999 ?

@stale stale bot removed the Stale label Jan 18, 2023
@niermann999
Copy link
Contributor Author

I think we could also merge this in the current state, what do you think @niermann999 ?

I do believe so, I don't remember why I kept it WIP

@niermann999 niermann999 removed the 🚧 WIP Work-in-progress label Jan 18, 2023
@github-actions
Copy link

github-actions bot commented Jan 18, 2023

📊 Physics performance monitoring for a00cef2

Full report
Seeding: seeded, truth estimated, orthogonal
CKF: seeded, truth smeared, truth estimated, orthogonal
IVF: seeded, truth smeared, truth estimated, orthogonal
Ambiguity resolution: seeded, orthogonal
Truth tracking
Truth tracking (GSF)

Vertexing

Vertexing vs. mu
IVF seeded

IVF truth_smeared

IVF truth_estimated

IVF orthogonal

Seeding

Seeding seeded

Seeding truth_estimated

Seeding orthogonal

CKF

CKF seeded

CKF truth_smeared

CKF truth_estimated

CKF orthogonal

Ambiguity resolution

seeded

Truth tracking (Kalman Filter)

Truth tracking

Truth tracking (GSF)

Truth tracking

@kodiakhq kodiakhq bot merged commit 5ea4c21 into acts-project:main Jan 18, 2023
@paulgessinger paulgessinger modified the milestones: next, v23.0.0 Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants