-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Description of ODD full chain example #1401
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1401 +/- ##
==========================================
- Coverage 48.59% 47.76% -0.83%
==========================================
Files 380 380
Lines 20577 20164 -413
Branches 9429 9387 -42
==========================================
- Hits 9999 9632 -367
+ Misses 4093 4083 -10
+ Partials 6485 6449 -36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few minor typos and missing language-denotations in codeblocks.
thank you for the extensive review @AJPfleger ! |
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
I wondered if you want to have a look at this @timadye |
Co-authored-by: Tim Adye <T.J.Adye@rl.ac.uk>
Co-authored-by: Tim Adye <T.J.Adye@rl.ac.uk>
Co-authored-by: Tim Adye <T.J.Adye@rl.ac.uk>
Sorry for all the nit-picking. I also have a couple of questions:
|
It's already linked, but empty here https://acts.readthedocs.io/en/latest/examples/full_chain_odd.html @timadye |
ad 1 the linking should already be done by #1387 ad 2 that is a good point I think we did not plan this @paulgessinger ? |
We didn't make a specific plan, but it might be a good idea to have an ITk doc like this one. Could create a stub and/or list in on the project I made (https://github.com/orgs/acts-project/projects/3/views/1)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks!
Walk-through / guide of ODD full chain example