fix: stop CKF branch if particle is stopped #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1454 +/- ##
==========================================
- Coverage 48.58% 48.57% -0.01%
==========================================
Files 381 381
Lines 20727 20741 +14
Branches 9497 9504 +7
==========================================
+ Hits 10070 10075 +5
- Misses 4110 4117 +7
- Partials 6547 6549 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
commented
Sep 7, 2022
andiwand
force-pushed
the
fix-ckf-stopped-particle-propagation
branch
from
9d59180
to
49cc7d1
Compare
AJPfleger
added
Improvement
paulgessinger
added
the
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Oct 11, 2022
in some special cases particles will be stopped while propagation in the CKF due to high energy losses. in this PR this is caught and the CKF branch will be dropped. additionally the error `NoTrackFound` was removed and CKF will only warn about that from now on. the abortlist was added to the CKF result because this is the only mutable state that is accessible. after a discussion with Paul we concluded that "result" is just a state and was designed for that anyways. see #1385 (comment) (cherry picked from commit f363d44)
paulgessinger
pushed a commit
that referenced
this pull request
Oct 12, 2022
…p/v19.x] (#1590) in some special cases particles will be stopped while propagation in the CKF due to high energy losses. in this PR this is caught and the CKF branch will be dropped. additionally the error `NoTrackFound` was removed and CKF will only warn about that from now on. the abortlist was added to the CKF result because this is the only mutable state that is accessible. after a discussion with Paul we concluded that "result" is just a state and was designed for that anyways. see #1385 (comment) Co-authored-by: Andreas Stefl <stefl.andreas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some special cases particles will be stopped while propagation in the CKF due to high energy losses. in this PR this is caught and the CKF branch will be dropped.
additionally the error
NoTrackFoundwas removed and CKF will only warn about that from now on.the abortlist was added to the CKF result because this is the only mutable state that is accessible. after a discussion with Paul we concluded that "result" is just a state and was designed for that anyways.
see #1385 (comment)