feat: check if yOuter takes the square root of a negative number when minHelixRadius < rMax / 2 in SpacePointGrid.ipp #1466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
added
Component - Core
Codecov Report
@@ Coverage Diff @@
## main #1466 +/- ##
==========================================
- Coverage 48.60% 48.59% -0.01%
==========================================
Files 380 380
Lines 20595 20597 +2
Branches 9433 9435 +2
==========================================
Hits 10010 10010
- Misses 4097 4099 +2
Partials 6488 6488
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
robertlangenberg
approved these changes
Sep 2, 2022
paulgessinger
added
the
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Sep 19, 2022
… minHelixRadius < rMax / 2 in SpacePointGrid.ipp (#1466) This PR adds a check to `SpacePointGrid.ipp` if `minHelixRadius` is smaller than `config.rMax / 2` as suggested in #1456. This happens if `rMax` of the grid in `mm` is greater than `2 x pT[GeV] / (3·10-4 × B[T])`. I am not sure if this combination of parameters makes sense in one specific detector configuration. @robertlangenberg (cherry picked from commit a1569de)
kodiakhq bot
pushed a commit
that referenced
this pull request
Sep 20, 2022
… minHelixRadius < rMax / 2 in SpacePointGrid.ipp [backport #1466 to develop/v19.x] (#1529) Backport a1569de from #1466. --- This PR adds a check to `SpacePointGrid.ipp` if `minHelixRadius` is smaller than `config.rMax / 2` as suggested in #1456. This happens if `rMax` of the grid in `mm` is greater than `2 x pT[GeV] / (3·10-4 × B[T])`. I am not sure if this combination of parameters makes sense in one specific detector configuration. @robertlangenberg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a check to
SpacePointGrid.ippifminHelixRadiusis smaller thanconfig.rMax / 2as suggested in #1456.This happens if
rMaxof the grid inmmis greater than2 x pT[GeV] / (3·10-4 × B[T]). I am not sure if this combination of parameters makes sense in one specific detector configuration.@robertlangenberg