-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updates to the seeding documentation #1476
docs: updates to the seeding documentation #1476
Conversation
The document starts with exclaimer that the intro section is outdated. Is it still needed? The intro is fairly general anyways. |
True, with this PR that should probably be removed. |
Can't comment o unchanged text. But I have simplifying suggestions about captions: If you have a chance to touch the plots can they be resized so that on each of them the detector has similar size. In general the explanations do not belong to the picture captions but should be part of the text. The explanation of the algorithm starts with phi-z projection. Maybe drawing of such projection could be useful? |
Thanks a lot @tboldagh for your comments! I will update this ASAP |
@tboldagh @paulgessinger |
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
Co-authored-by: Paul Gessinger <hello@paulgessinger.com>
not sure why the docs are failing |
I think its
I'm guessing you need to add the |
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
Thanks a lot @AJPfleger for your comments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just read this seeding chapter and found it really good and descriptive, with nice figures, really good work. I think this can go in!
Thanks for your revision @benjaminhuth |
By mistake I forgot to add a caption to one of the figures from #1476
Some updates to the seeding documentation