Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make JsonMaterialDecorator IO error more explicit #1500

Merged
merged 2 commits into from
Sep 7, 2022
Merged

fix: Make JsonMaterialDecorator IO error more explicit #1500

merged 2 commits into from
Sep 7, 2022

Conversation

paulgessinger
Copy link
Member

This has caused confusion because the error doesn't mention which file it's actually trying to open.

@paulgessinger paulgessinger added this to the next milestone Sep 7, 2022
@codecov
Copy link

codecov bot commented Sep 7, 2022 •
edited

Codecov Report

Merging #1500 (6c55572) into main (433a379) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1500   +/-   ##
=======================================
  Coverage   48.59%   48.59%           
=======================================
  Files         381      381           
  Lines       20631    20631           
  Branches     9463     9463           
=======================================
  Hits        10026    10026           
  Misses       4066     4066           
  Partials     6539     6539

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Corentin-Allaire
Corentin-Allaire approved these changes Sep 7, 2022
View reviewed changes
Copy link
Contributor

@Corentin-Allaire Corentin-Allaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the Jira ticket, it's great that you added this.

@kodiakhq kodiakhq bot merged commit 087ed98 into acts-project:main Sep 7, 2022
@github-actions github-actions bot removed the automerge label Sep 7, 2022
@paulgessinger paulgessinger added the backport develop/v19.x Backport this PR to the v19.x series label Sep 19, 2022
acts-project-service pushed a commit that referenced this pull request Sep 19, 2022
@paulgessinger @github-actions
fix: Make JsonMaterialDecorator IO error more explicit (#1500)
c99c846 
This has caused confusion because the error doesn't mention which file it's actually trying to open.

(cherry picked from commit 087ed98)
@acts-project-service acts-project-service mentioned this pull request Sep 19, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Sep 20, 2022
@acts-project-service
fix: Make JsonMaterialDecorator IO error more explicit [backport #1500 …
af87624 
…to develop/v19.x] (#1528)

Backport 087ed98 from #1500.
---
This has caused confusion because the error doesn't mention which file it's actually trying to open.
@paulgessinger paulgessinger modified the milestones: next, v20.2.0 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Corentin-Allaire Corentin-Allaire Corentin-Allaire approved these changes

Assignees
No one assigned
Labels
backport develop/v19.x Backport this PR to the v19.x series
Projects
None yet
Milestone
v20.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulgessinger @Corentin-Allaire