Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ParticleSmearing options not setup in AMVF example exe #1508

Merged

Conversation

paulgessinger
Copy link
Member

Missing call to addParticleSmearingOptions.

Fixes #1506

Missing call to `addParticleSmearingOptions`.

Fixes acts-project#1506
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1508 (cb2f2e7) into main (d9816f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1508   +/-   ##
=======================================
  Coverage   48.47%   48.47%           
=======================================
  Files         381      381           
  Lines       20699    20699           
  Branches     9503     9503           
=======================================
  Hits        10034    10034           
  Misses       4112     4112           
  Partials     6553     6553           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@andiwand andiwand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this!

@paulgessinger paulgessinger added automerge backport develop/v19.x Backport this PR to the v19.x series labels Sep 19, 2022
@kodiakhq kodiakhq bot merged commit 896b47e into acts-project:main Sep 19, 2022
acts-project-service pushed a commit that referenced this pull request Sep 19, 2022
Missing call to `addParticleSmearingOptions`.

Fixes #1506

(cherry picked from commit 896b47e)
kodiakhq bot pushed a commit that referenced this pull request Sep 20, 2022
…1508 to develop/v19.x] (#1534)

Backport 896b47e from #1508.
---
Missing call to `addParticleSmearingOptions`.

Fixes #1506
@paulgessinger paulgessinger modified the milestones: next, v20.2.0 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport develop/v19.x Backport this PR to the v19.x series
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while i run ActsExampleAdaptiveMultiVertexFinder
2 participants