Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update logging doc, add info on thresholds #1520

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

paulgessinger
Copy link
Member

This mainly adds information on the logging thresholds configuration.

@paulgessinger paulgessinger added the Component - Documentation Affects the documentation label Sep 14, 2022
@paulgessinger paulgessinger added this to the next milestone Sep 14, 2022
@paulgessinger paulgessinger mentioned this pull request Sep 14, 2022
10 tasks
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #1520 (a0ada34) into main (df05834) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #1520   +/-   ##
=======================================
  Coverage   48.58%   48.58%           
=======================================
  Files         381      381           
  Lines       20629    20651   +22     
  Branches     9464     9476   +12     
=======================================
+ Hits        10023    10034   +11     
+ Misses       4066     4064    -2     
- Partials     6540     6553   +13     
Impacted Files Coverage Δ
Core/include/Acts/Utilities/Logger.hpp 56.97% <0.00%> (-0.68%) ⬇️
Core/src/Utilities/Logger.cpp 30.43% <0.00%> (ø)
...e/include/Acts/EventData/VectorMultiTrajectory.hpp 52.89% <0.00%> (-2.66%) ⬇️
...re/include/Acts/TrackFitting/GaussianSumFitter.hpp 69.18% <0.00%> (-1.17%) ⬇️
.../include/Acts/TrackFitting/detail/GsfSmoothing.hpp 35.05% <0.00%> (-0.37%) ⬇️
Core/include/Acts/Vertexing/ZScanVertexFinder.hpp 81.81% <0.00%> (ø)
...e/include/Acts/Vertexing/IterativeVertexFinder.hpp 82.35% <0.00%> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFinder.hpp 78.57% <0.00%> (ø)
...clude/Acts/Vertexing/AdaptiveMultiVertexFitter.hpp 72.00% <0.00%> (ø)
Core/include/Acts/TrackFitting/detail/GsfActor.hpp 42.58% <0.00%> (+0.21%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benjaminhuth
Copy link
Member

benjaminhuth commented Sep 14, 2022

Very nice and understandable. After reading through, I found that there is one part where I would expect a link or something to CustomDefaultLogger.cpp in line 128.

This is not in the part that you changed, but maybe you could add a link here @paulgessinger?

@paulgessinger
Copy link
Member Author

Added now, @benjaminhuth.

@paulgessinger
Copy link
Member Author

Minor change since @benjaminhuth's approval. I'll merge this.

@paulgessinger paulgessinger merged commit 33ce28f into acts-project:main Sep 16, 2022
@paulgessinger paulgessinger deleted the docs/logging-update branch September 16, 2022 07:47
@paulgessinger paulgessinger modified the milestones: next, v20.2.0 Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Documentation Affects the documentation
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants