fix: Add required flags to cmdline args in analysis scripts #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
benjaminhuth
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1570 +/- ##
=======================================
Coverage 48.47% 48.47%
=======================================
Files 381 381
Lines 20699 20699
Branches 9503 9503
=======================================
Hits 10034 10034
Misses 4112 4112
Partials 6553 6553 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andiwand
approved these changes
Oct 4, 2022
paulgessinger
added
the
backport develop/v19.x
acts-project-service
pushed a commit
that referenced
this pull request
Oct 7, 2022
The analysis scripts could fail with `boost::any_cast` errors if some arguments where not provided. However, what arguments exactely could only be found out in the source code. This adds a few required flags that explicitly say what is needed. (cherry picked from commit 1941fbc)
paulgessinger
pushed a commit
that referenced
this pull request
Oct 11, 2022
…1570 to develop/v19.x] (#1585) The analysis scripts could fail with `boost::any_cast` errors if some arguments where not provided. However, what arguments exactely could only be found out in the source code. This adds a few required flags that explicitly say what is needed. Co-authored-by: Benjamin Huth <37871400+benjaminhuth@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The analysis scripts could fail with
boost::any_casterrors if some arguments where not provided. However, what arguments exactely could only be found out in the source code.This adds a few required flags that explicitly say what is needed.