-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: break loop over triplets in seed finder #1576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuisFelipeCoelho
changed the title
break loop over triplets in seed finder
feat: break loop over triplets in seed finder
Oct 6, 2022
LuisFelipeCoelho
added
Component - Core
Affects the Core module
Improvement
Changes to an existing feature
Impact - Minor
Nuissance bug and/or affects only a single module
labels
Oct 6, 2022
Codecov Report
@@ Coverage Diff @@
## main #1576 +/- ##
==========================================
- Coverage 48.57% 48.57% -0.01%
==========================================
Files 381 381
Lines 20741 20743 +2
Branches 9504 9505 +1
==========================================
Hits 10075 10075
- Misses 4117 4119 +2
Partials 6549 6549
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AJPfleger
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@LuisFelipeCoelho, could you update the branch?
paulgessinger
pushed a commit
to paulgessinger/acts
that referenced
this pull request
Oct 20, 2022
break loop over triplets if reached the last top SP in seed finder to avoid unnecessary calculations
paulgessinger
pushed a commit
that referenced
this pull request
Oct 20, 2022
break loop over triplets if reached the last top SP in seed finder to avoid unnecessary calculations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backported to develop/v19.x ✅
Component - Core
Affects the Core module
Impact - Minor
Nuissance bug and/or affects only a single module
Improvement
Changes to an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
break loop over triplets if reached the last top SP in seed finder to avoid unnecessary calculations