Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: break loop over triplets in seed finder #1576

Merged
merged 4 commits into from
Oct 11, 2022

Conversation

LuisFelipeCoelho
Copy link
Member

break loop over triplets if reached the last top SP in seed finder to avoid unnecessary calculations

@LuisFelipeCoelho LuisFelipeCoelho changed the title break loop over triplets in seed finder feat: break loop over triplets in seed finder Oct 6, 2022
@LuisFelipeCoelho LuisFelipeCoelho added Component - Core Affects the Core module Improvement Changes to an existing feature Impact - Minor Nuissance bug and/or affects only a single module labels Oct 6, 2022
@LuisFelipeCoelho LuisFelipeCoelho added this to the next milestone Oct 6, 2022
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1576 (9282024) into main (f363d44) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1576      +/-   ##
==========================================
- Coverage   48.57%   48.57%   -0.01%     
==========================================
  Files         381      381              
  Lines       20741    20743       +2     
  Branches     9504     9505       +1     
==========================================
  Hits        10075    10075              
- Misses       4117     4119       +2     
  Partials     6549     6549              
Impacted Files Coverage Δ
Core/include/Acts/Seeding/Seedfinder.ipp 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@AJPfleger AJPfleger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@LuisFelipeCoelho, could you update the branch?

@kodiakhq kodiakhq bot merged commit f1489ce into acts-project:main Oct 11, 2022
@LuisFelipeCoelho LuisFelipeCoelho deleted the cpu-break-loop branch October 11, 2022 14:07
paulgessinger pushed a commit to paulgessinger/acts that referenced this pull request Oct 20, 2022
break loop over triplets if reached the last top SP in seed finder to avoid unnecessary calculations
paulgessinger pushed a commit that referenced this pull request Oct 20, 2022
break loop over triplets if reached the last top SP in seed finder to avoid unnecessary calculations
@paulgessinger paulgessinger modified the milestones: next, v21.0.0 Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported to develop/v19.x ✅ Component - Core Affects the Core module Impact - Minor Nuissance bug and/or affects only a single module Improvement Changes to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants