fix: non finite weight handling in GSF #1591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminhuth
added
Bug
AJPfleger
reviewed
Oct 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1591 +/- ##
==========================================
- Coverage 48.54% 48.54% -0.01%
==========================================
Files 381 381
Lines 20782 20785 +3
Branches 9534 9536 +2
==========================================
+ Hits 10089 10090 +1
Misses 4112 4112
- Partials 6581 6583 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AJPfleger
reviewed
Oct 11, 2022
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
AJPfleger
approved these changes
Oct 11, 2022
benjaminhuth
changed the title
|
@AJPfleger I found some other issues related to non finite weights, so I thought that could also be included in this PR to limit the number of PRs. Could you have a look again and reapprove is everything is fine? Thanks! |
AJPfleger
reviewed
Oct 12, 2022
Co-authored-by: Alexander J. Pfleger <70842573+AJPfleger@users.noreply.github.com>
AJPfleger
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error where a
throw_assertchecking if all components weight sums up to 1 could trigger when all components have statusmissedw.r.t. the next navigation surface. Requires a bit of rearrangement to check this beforehand.